Fix #2795: Fix name kind testing logic #2798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic would have UniqueNames shadow everything else. So if one starts with a UniqueName(prefix, sep, number), and then does a qualified name, one gets a unique name or a qualified name. the resulting name should still be recognized as a qualified name, however. The change in this commit achieves that.
When enabled, we print trees with their uniqueIds. This was useful in diagnosing the issue, because that way we could find out when a tree that was missing in one version was created in the other.
smarter
reviewed
Jun 23, 2017
| @@ -233,17 +233,25 @@ object Names { | |||
| } | |||
| } | |||
|
|
|||
| /** Is it impossible that trees of kind `kind` qualify as | |||
There was a problem hiding this comment.
you mean names, not trees, right?
nicolasstucki
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic would have UniqueNames shadow everything else. So if one starts
with a UniqueName(prefix, sep, number), and then does a qualified name, one gets a
unique name over a qualified name. The resulting name should still be recognized as a
qualified name, however. The change in this commit achieves that.